KAFKA-18887 Implement Streams Admin APIs #19049
Conversation
There was a problem hiding this comment.
Thanks for the PR, @aliehsaeedii ! I made a pass on the production code.
| import java.util.Map; | ||
|
|
||
| /** | ||
| * The result of the {@link AdminClient#alterConsumerGroupOffsets(String, Map)} call. |
There was a problem hiding this comment.
This is the result of alterStreamsGroupOffsets
| * The API of this class is evolving, see {@link Admin} for details. | ||
| */ | ||
| @InterfaceStability.Evolving | ||
| public class DeleteStreamsGroupOffsetsResult extends DeleteConsumerGroupOffsetsResult { |
There was a problem hiding this comment.
I don't think we should use inheritance here. There is no subtyping relationship here really. Also, technically this is a change to the public API that needs to be changed in the KIP.
I understand you want to avoid reimplementing the class. Have you considered using delegation? That is, the (package-protected) contructor for this class takes a DeleteConsumerGroupOffsetsResult and delegates calls to partitionResult and all to it?
| * The API of this class is evolving, see {@link AdminClient} for details. | ||
| */ | ||
| @InterfaceStability.Evolving | ||
| public class AlterStreamsGroupOffsetsOptions extends AlterConsumerGroupOffsetsOptions { |
There was a problem hiding this comment.
I would directly derive from AbstractOptions<AlterStreamsGroupOffsetsOptions> here. Similar for the other option classes.
| @@ -945,6 +945,29 @@ default ListConsumerGroupOffsetsResult listConsumerGroupOffsets(Map<String, List | |||
| return listConsumerGroupOffsets(groupSpecs, new ListConsumerGroupOffsetsOptions()); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
For all the javadocs for methods in the Admin, I'd suggest we add a @note that this effectively does the same as the corresponding consumer group method.
https://issues.apache.org/jira/browse/KAFKA-18887