Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLIENT PAUSE and CLIENT REPLY subcommands #2495

Open
wants to merge 14 commits into
base: unstable
Choose a base branch
from

Conversation

furkan-bilgin
Copy link

This PR is a part of #2422

I have added two subcommands for the command CLIENT:

  • CLIENT PAUSE: Pauses processing of either WRITE or ALL commands until after timeout milliseconds.
  • CLIENT REPLY: Stops server from sending replies to the client, starting; immediately if OFF, or skips one if SKIP. Starts sending replies if ON.

@git-hulk git-hulk requested review from git-hulk, torwig and PragmaTwice and removed request for git-hulk, torwig and PragmaTwice August 18, 2024 14:10
src/commands/cmd_server.cc Outdated Show resolved Hide resolved
src/server/redis_connection.cc Outdated Show resolved Hide resolved
@git-hulk
Copy link
Member

@furkan-bilgin Thanks for your contribution. Could you please help to pass the CI lint according to https://github.com/apache/kvrocks/actions/runs/10441248380/job/28912245323?pr=2495

Copy link

sonarcloud bot commented Sep 1, 2024

@git-hulk
Copy link
Member

git-hulk commented Sep 6, 2024

@furkan-bilgin Looks good if you can add some Go test cases to cover this. And another point is that we should disable the EV_READ for connection while pausing?

Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests should be added to demonstrate the functionality of the software as it includes changes in the critical execution path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants