Avoid unnecessary memory allocation in PackedLongValues#Iterator (#13439

) We always allocate a long array of page size for a new PackedLongValues#Iterator instance, which is not necessary when packing a small number of values. this is more evident in the scenario of high-frequency flush operations
apache · Jun 4, 2024 · e8801bf · e8801bf
1 parent bff14fb
commit e8801bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
@@ -19,7 +19,8 @@ Improvements
 
 Optimizations
 ---------------------
-(No changes)
+
+* GITHUB#13439: Avoid unnecessary memory allocation in PackedLongValues#Iterator. (Zhang Chao)
 
 Bug Fixes
 ---------------------

diff --git a/lucene/core/src/java/org/apache/lucene/util/packed/PackedLongValues.java b/lucene/core/src/java/org/apache/lucene/util/packed/PackedLongValues.java
@@ -138,7 +138,7 @@ public final class Iterator {
     int currentCount; // number of entries of the current page
 
     Iterator() {
-      currentValues = new long[pageMask + 1];
+      currentValues = new long[(int) Math.min(size, pageMask + 1)];
       vOff = pOff = 0;
       fillBlock();
     }