-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and javadoc update for KNN vector writer classes #13548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Some minor concerns to ensure the new method isn't abused.
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java
Outdated
Show resolved
Hide resolved
@@ -356,7 +356,7 @@ BufferedUpdate next() throws IOException { | |||
} | |||
} | |||
|
|||
BytesRef nextTerm() throws IOException { | |||
private BytesRef nextTerm() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like an extra thing out of nowhere? Its probably ok in this commit, just struck me as a strange inclusion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just edited it when I was going over the code, thought it should be fine leaving it here :)
Description