Introduce TestLucene90DocValuesFormatVariableSkipInterval for testing docvalues skipper index #13550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
reviewed
Jul 8, 2024
lucene/test-framework/src/java/org/apache/lucene/tests/codecs/skipper/SkipperCodec.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java
Outdated
Show resolved
Hide resolved
iverase
changed the title
|
@jpountz I added a new test and change the title and description of the issue as we don't need to add a new Codec. |
jpountz
approved these changes
Jul 9, 2024
| @@ -96,6 +97,7 @@ public Lucene90DocValuesConsumer( | |||
| state.segmentInfo.getId(), | |||
| state.segmentSuffix); | |||
| maxDoc = state.segmentInfo.maxDoc(); | |||
| this.skipIndexIntervalSize = skipIndexIntervalSize; | |||
There was a problem hiding this comment.
Do we make any assumption anywhere that this needs to be a power of two? If so we should validate it?
There was a problem hiding this comment.
No , there is no assumption. On the other hand I added in the codec a check so skipIndexIntervalSize must be 1. In addtion I replace 1 << x by an integer to remove the suggestion that this is required.
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesFormat.java
Outdated
Show resolved
Hide resolved
.../test/org/apache/lucene/codecs/lucene90/TestLucene90DocValuesFormatVariableSkipInterval.java
Outdated
Show resolved
Hide resolved
iverase
changed the title
jpountz
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13449 we introduced a sparse index on top of doc values. One of the challenges was to properly test it as the default interval size is 4096 documents so we need a fair amount of documents to have a good number of intervals.
Therefore in this commit we propose to be able to configure dynamically the interval size for testing, and add a new test that changes the interval size randomly.