Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Ensure to use IOContext.READONCE when reading segment files #13578

Merged
merged 5 commits into from
Jul 17, 2024
Merged

[9.x] Ensure to use IOContext.READONCE when reading segment files #13578

merged 5 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. [9.x] Ensure to use IOContext.READONCE when reading segment files (ap… 

    …ache#13574)

This commit uses IOContext.READONCE in more places where the index input is clearly being read once by the thread opening it. We can then enforce that segment files are only opened with READONCE, in the test specific Mock directory wrapper.

Much of the changes in this PR update individual test usage, but there is one non-test change to Directory::copyFrom.
    @ChrisHegarty
    ChrisHegarty committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    745881e View commit details
    Browse the repository at this point in the history

  2. use READONCE for SegmentInfos::readCommit

    @ChrisHegarty
    ChrisHegarty committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8d10ee5 View commit details
    Browse the repository at this point in the history

  3. another READONCE for checksum input in test

    @ChrisHegarty
    ChrisHegarty committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a90a37f View commit details
    Browse the repository at this point in the history

  4. tidy

    @ChrisHegarty
    ChrisHegarty committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e095aff View commit details
    Browse the repository at this point in the history

  5. check context.readOnce

    @ChrisHegarty
    ChrisHegarty committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    19913a2 View commit details
    Browse the repository at this point in the history