-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Static field cleanup, #662, #679 #1079
base: master
Are you sure you want to change the base?
Conversation
Converted to draft; I'm going to include the related #679 changes as well. Update: this is complete. |
@NightOwl888 I'm iffy on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this has been reviewed, but this is still partially complete. But I'm passing on my comments so you can make some of the updates now.
Converts static readonly fields to const, where possible. Also addresses csharpsquid:S2223 issues with mutable static fields.
Fixes #662
Fixes #679
Description
This PR converts most static readonly fields to const where it is possible to do so. Some notable exceptions:
This also addresses #679 with non-readonly static fields, where one of three things happened: