changes made for Redundant jump statements #684

[sachdevlaksh]

Changes provided for Issue #684

[NightOwl888]

Thanks for the PR.

While you did follow the instructions that were provided in #684, they were unfortunately not detailed enough (our fault). Please make the following changes to every changed line:

1. The "link to related SonarCloud issue" was meant to be a permanent link to a SonarCloud document that describes the issue (similar to how Microsoft does CA1812). Unfortunately, no such document for "SonarCloud S3626" comes up in a Google search, I had to search for "Code Analysis S3626" to get a hit: https://rules.sonarsource.com/csharp/RSPEC-3626. This SonarCloud scan setup is temporary, not a permanent URL that we should put in the source code. We are working on an official SonarCloud setup in ci: Added sonar workflow #709, but it isn't ready yet.
2. Do not add an additional line for the comment, place the comment after the code that is commented on the same line. Include the // also.

Example

// continue; // LUCENENET: Removed redundant jump statements. https://rules.sonarsource.com/csharp/RSPEC-3626

[sachdevlaksh]

Thanks for the PR.

While you did follow the instructions that were provided in #684, they were unfortunately not detailed enough (our fault). Please make the following changes to every changed line:

1. The "link to related SonarCloud issue" was meant to be a permanent link to a SonarCloud document that describes the issue (similar to how Microsoft does CA1812). Unfortunately, no such document for "SonarCloud S3626" comes up in a Google search, I had to search for "Code Analysis S3626" to get a hit: https://rules.sonarsource.com/csharp/RSPEC-3626. This SonarCloud scan setup is temporary, not a permanent URL that we should put in the source code. We are working on an official SonarCloud setup in ci: Added sonar workflow #709, but it isn't ready yet.
2. Do not add an additional line for the comment, place the comment after the code that is commented on the same line. Include the // also.

Example

// continue; // LUCENENET: Removed redundant jump statements. https://rules.sonarsource.com/csharp/RSPEC-3626

Thanks @NightOwl888, For the detail, I make changes asap.