Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behaviour around 'destDir' naming #113

Closed
wants to merge 1 commit into from

Conversation

ascopes
Copy link
Contributor

@ascopes ascopes commented May 11, 2024

It appears the current codebase is set up to explicitly ignore the 'destDir' parameter if it does not explicitly end with the string 'xref'. This is currently unclear in the documentation and is only able to be discovered upon reading the source code itself.

This behaviour can be seen at

@Override
public void setReportOutputDirectory(File reportOutputDirectory) {
if ((reportOutputDirectory != null)
&& (!reportOutputDirectory.getAbsolutePath().endsWith("xref"))) {
this.destDir = new File(reportOutputDirectory, "xref").getAbsolutePath();
} else {
this.destDir = reportOutputDirectory.getAbsolutePath();
}
}
}
.

It appears the current codebase is set up to explicitly ignore
the 'destDir' parameter if it does not explicitly end with the 
string 'xref'. This is currently unclear in the documentation and
is only able to be discovered upon reading the source code itself.
@michael-o
Copy link
Member

Thank you for your PR, that parameter along with other inconsistencies have already been cleaned up/removed in #64. I hope to merge that this summer.

@michael-o michael-o closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants