Simplify maven-bundle-plugin configuration #343
Conversation
HannesWell
force-pushed
the
simplify_bundle-plugin_config
branch
2 times, most recently
from
462549a
to
e2b6caa
Compare
Instead of the 'maven-bundle-plugin:cleanVersions' goal, use BND-lib's range macro: https://bnd.bndtools.org/macros/range.html Additionally use angular brackets for BND-macros (https://bnd.bndtools.org/chapters/850-macros.html) and make the version-ranges for imported sshd packages more strict.
HannesWell
force-pushed
the
simplify_bundle-plugin_config
branch
from
e2b6caa
to
9a384bb
Compare
|
Thank you @tomaswolf. Can you tell me if there are already plans for the next release of sshd or can you give a rough estimate? |
|
I had seen that question in the other PR; was getting around to it :-) We have no release plan; we release whenever we feel it's needed and our release manager has the time to do so. Luckily we don't have a lot in the pipeline currently, and no blocker bugs. If we want to have that new release used in Eclipse 2023-06, we should target a new Apache MINA sshd release for Eclipse 2023-06 M3 (2023-05-26). I'll need some time to prepare a JGit version using the new release. (First, I run the JGit SSH tests as part of my approval of an Apache MINA sshd release, and second, we'd want the new JGit in that Eclipse to use the new Apache MINA sshd release anyway.) I don't think I'll get to that before April 15. So a reasonable timeframe for a new Apache MINA sshd release would be "first half of May". That would give me a little time to get the JGit changes in before M3. I suggest we go to version 2.10; there are some API changes. @gnodet, would you be available beginning of May to do a new release? |
Glad to hear that.
Thank you, it would be really great and highly appreciated to have the mentioned changes released in time for Eclipse 2023-06 and the previous version of sshd replaced by the new one, so that the Eclipse SimRel can complete the shift to sfl4j-2. |
|
I've created JGit issue 581770 to track the JGit update. |
Great. Would it be possible to deploy a snapshot version of the current state of sshd to any snapshot repo, e.g. the one of Apache? That would allow to test the current state in verification builds. |
I'll try to do that next week. Is there any remaining issue/PR to look at ? |
@gnodet: none except your own #362, which I think should also go in that release. (But it has to pass the CI build first. Looks like there's still some work needed in the tests. Plus it should be mentioned in CHANGES.md when it goes in.) Otherwise I think we're good to go. There's also the closed issue #294, which perhaps wasn't quite fixed by PR #295 according to comments, but for which I have no reproducer. It's about a memory leak involving ThreadLocals in SftpFileSystemProvider, which might be your area of expertise :-). |
Thanks! |
Instead of the 'maven-bundle-plugin:cleanVersions' goal, use BND-lib's range macro:
https://bnd.bndtools.org/macros/range.html
@tomaswolf maybe you are interested in this as well?