Bump org.apache.mina:mina-core from 2.0.23 to 2.2.3 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.apache.mina:mina-core](https://github.com/apache/mina) from 2.0.23 to 2.2.3. - [Commits](apache/mina@2.0.23...2.2.3) --- updated-dependencies: - dependency-name: org.apache.mina:mina-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
Uh... are we ready to abandon the 2.0.x stream of Apache MINA? I know for certain that Gerrit uses the MINA transport back-end with MINA 2.0.25. Jumping to 2.2.3 might incur a lot of testing work. |
|
Given that a MINA 2.2.4 is forthcoming, I think the correct way forward here would be
|
|
We can't add the method as it has a |
|
@gnodet: yes, I know. But if Apache MINA makes it a default method, then we don't have to declare it at all, and thus we can at least support 2.0.x and >= 2.2.4 with the same code. Yes, we cannot support 2.0.x and (2.1.x or <=2.2.3) at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.apache.mina:mina-core from 2.0.23 to 2.2.3.
Commits
906884d[maven-release-plugin] prepare release 2.2.3abeddb9Downgraded the maven source plugin version because 3.3.0 fails677e729o Bumped up dependencies and maven polugins48de5d2Ignore the test, otherwise it will loop forever1a7c450Renamed the DIRMINA1172 test3e638d1Merge remote-tracking branch 'origin/2.2.X' into 2.2.Xc723045Fix for DIRMINA-117226f6f99Use the diamond notation0145d1aUse stock JRE Charset instead of magic string269aef1Use stock JRE Charset instead of magic stringYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)