include php blade plugin in php cluster

[haidubogdan]

Laravel is one of the most used frameworks in php, yet it still doesn't have support in Netbeans. (#7531 , #7231).
Mostly the main missing support is for blade templates syntax.

I've started to work on a plugin https://github.com/haidubogdan/netbeans-php-blade-plugin 3 years ago.
After using antlr as a lexer and parser, I found that scaling the plugin was much maintainable.
It's not the cleanest code, but I realized that I will always reach to the 99% finish status if I don't do the first pull request.

Most of the available features to be included are listed at https://github.com/haidubogdan/netbeans-php-blade-plugin.

• syntax highlighting
• blade syntax completion
• declaration finder for specific blade template
  ....

And some are still missing

• php embedded syntax validation
• more advanced php syntax completion.

All feedbacks are welcome, I hope to reach nb 23 deployment :) .

TODO

• Submit an ICLA (sent on 3 august)
• Change to the full name in commits
• Check the license of the image (no response received from Tailor [laravel], using personal icon)
• Add unit tests
• Write all features with screenshots

[junichi11]

First of all, thank you for your contribution!

I hope to reach nb 23 deployment

Unfortunately, it's too late. The feature freeze date is July 26th.

Please write all features of this module with screenshots here as well. (not only the link)

Please add unit tests for features. e.g. code completion, indexer, navigator, parser, lexer, formatter etc. (also see: CslTestBase.java)

Did you submit an ICLA?

Probably, it takes a lot of time to review this.

[haidubogdan]

Hi,
thank you for your feedback.
I will prepare the unit tests. ( I hope the base parser unit test classes will be available now that it's included in the IDE folder).
I didn't submit the ICLA. I will read about it.

[junichi11]

How did you generate icons? (Are there icons based on something?)

https://github.com/apache/netbeans/pull/7618/files#diff-24c53d9c7defe885e1ee8adee9ff009c57d69e75621ad84625d8f9eaa8d7c9e1

[junichi11]

Can change these("\\") to constants?

[junichi11]

What does 3 mean?
// NOI18N

[junichi11]

Please check whether we should translate yourself once for strings of all files. (add // NOI18N or @Messages)
Please check whether annotations are needed. (e.g. @CheckForNull, @NullAllowed,...)

[mbien]

don't forget to hook the tests into CI so that we can let it run over this PR - just in case there are any surprises.

would look like:

netbeans/.github/workflows/main.yml

Lines 2404 to 2405 in a5fa02d

	- name: php.latte
	run: ant $OPTS -f php/php.latte test

and someone can trigger the workflow once done

[mbien]

you sure parallelStream() is a good idea here? It always comes with setup and runtime overhead and all this stream does is to filter a set - so the parallel task itself is tiny.

I would only recommend using parallel streams if it is also demonstrated in a benchmark that they make a difference in that usecase.

[haidubogdan]

It was a borrowed implementation, so I think I could simplify the flow to use simple stream

[mbien]

not sure I understand, I have nothing against the stream usage itself. But the fact that parallelStream() is used instead of stream().

[mbien]

oh I think I get what you mean, there are two getExpiredKeys() methods which use parallelStream() you updated one so far. I didn't realize that there were two sorry.

[haidubogdan]

Ah no :).
It was a short comment about my intention to replace the usage of parallelStream() with stream(), but I wasn't very clear.

[mbien]

List.of would make this immutable. Should this be a Set? (see next comment)

[mbien]

unfortunately this didn't solve the issue :(

the array and the set are both mutable + you don't seem to use the array anywhere outside of this class.

public static final Set<Integer> TOKENS_WITH_IDENTIFIABLE_PARAM = Set.of(
    D_EXTENDS, D_INCLUDE, D_INCLUDE_IF, D_INCLUDE_WHEN,
    D_INCLUDE_UNLESS, D_EACH, D_SECTION, D_HAS_SECTION, D_SECTION_MISSING,
    D_PUSH, D_PUSH_IF, D_PREPEND, D_USE, D_INJECT, D_ASSET_BUNDLER
);

This would make it immutable.

you are using in many places lines like: new HashSet<>(Arrays.asList(new String[]{directive})); which could be Set.of(directive).

[mbien]

regarding generated code. I believe we ended up agreeing to try to generate antlr outputs during build but don't commit it to the repo. The reason is because generated antlr code is not very "stable", it produces huge diffs when the version updates and those aren't reviewable anyway. (e.g the marked section)

The second reason would be antlr updates, this makes sure the code fits to the version if someone happens to update the antlr lib at some point.

example: #7189, #7186 etc

cc @neilcsmith-net @lkishalmi

[haidubogdan]

Ok, I will see how I can add it to .gitignore and have them build before the unit tests.
@junichi11 is it ok for you if I remove the generated antlr parser and lexer files from git ?