Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed changes in comments while renaming #7724

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

subhash-arabhi
Copy link
Contributor

These changes fix this issue

Brief

While using renaming functionality, netbeans changes occurrence of the word in the comments, without any context

@lahodaj
Copy link
Contributor

lahodaj commented Sep 5, 2024

I was thinking if this should be configurable, but I don't think we can currently realistically add an option to the refactoring itself, and adding to the "global" settings also feels weird. So, I guess I am generally mostly fine with this. @dbalek - please look as well - thanks!

@lahodaj lahodaj requested a review from dbalek September 5, 2024 09:12
@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Sep 5, 2024
@lahodaj lahodaj added this to the NB24 milestone Sep 5, 2024
@apache apache locked and limited conversation to collaborators Sep 10, 2024
@apache apache unlocked this conversation Sep 10, 2024
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lahodaj lahodaj merged commit 4d10c98 into apache:master Oct 22, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants