Editor: Enable display of characters unsupported by chosen editor font #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed, that in some contexts Swing was able to display characters unsupported by the currently chosen font. The problem was observed with emojis. Investigation showed, that the problem appears if a font is explicitly constructed via the constructor, but vanishes if the font is accessed via StyleContext#getFont. The difference is that StyleContext#getFont returns a CompositeFont, that fallsback to other fonts for undefined glyphs. As CompositeFont is located in the sun.font package, it can't be accessed directly. Instead the font acccess via the DefaultStyleContext is used.
matthiasblaesing
added
Platform
|
I intent to merge this next weekend. If anyone wants to object, now would be a good time. |
mbien
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed, that in some contexts Swing was able to display characters unsupported by the currently chosen font. The problem was observed with emojis. Investigation showed, that the problem appears if a font is explicitly constructed via the constructor, but vanishes if the font is accessed via StyleContext#getFont.
The difference is that StyleContext#getFont returns a CompositeFont, that fallsback to other fonts for undefined glyphs.
As CompositeFont is located in the sun.font package, it can't be accessed directly. Instead the font acccess via the DefaultStyleContext is used.
Before:
After:
