Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Client: Reduce concurrency in LSP communication and register document sychronously on startup #7759

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

matthiasblaesing
Copy link
Contributor

  • Run open document registration in LSP servers synchronously with initialization
  • Instead of spinning custom RequestProcessors use the existing queue on the LSP Bindings via runOnBackground
  • Where possible drop RequestProcessor usage and run code directly

Closes: #3812

…ment sychronously on startup

- Run open document registration in LSP servers synchronously with
  initialization
- Instead of spinning custom RequestProcessors use the existing queue
  on the LSP Bindings via runOnBackground
- Where possible drop RequestProcessor usage and run code directly

Closes: apache#3812
@matthiasblaesing matthiasblaesing added LSP [ci] enable Language Server Protocol tests C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 16, 2024
@matthiasblaesing matthiasblaesing added this to the NB24 milestone Sep 16, 2024
Copy link
Contributor

@vieiro vieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks, @matthiasblaesing !

@matthiasblaesing
Copy link
Contributor Author

I intent to merge this next weekend. If anyone wants to object, now would be a good time.

@matthiasblaesing matthiasblaesing merged commit 087887d into apache:master Oct 12, 2024
31 checks passed
@matthiasblaesing matthiasblaesing deleted the lsp_initfix branch October 18, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) LSP [ci] enable Language Server Protocol tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ide/lsp.client add opened documents after start
2 participants