Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: process scheduler before wd_timer handler #13778

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

zyfeier
Copy link
Contributor

@zyfeier zyfeier commented Oct 2, 2024

Summary

wd_timer handler will change current task, so need process scheduler before wd timer handler, Ensure that the current task is not updated before the RR process.

Impact

RR sched with tickless

Testing

Test with sabre-6quad, config CONFIG_RR_INTERVAL

wd_timer handler will change current task, so need process
scheduler before wd timer handler, Ensure that the current
task is not updated before the RR process

Signed-off-by: zhangyuan29 <[email protected]>
@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Oct 2, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 2, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • The "why" is not clear. Why is changing the task in the watchdog timer handler a problem?
    • What is the specific change being made to the code? Be explicit.
    • No related issue references provided.
  • Impact:
    • Vague. Provide specific details for each impact category (e.g., which architectures, boards, or drivers are affected). Explain how the build process changes.
  • Testing:
    • Incomplete.
      • Specify the host OS, CPU, and compiler used for testing.
      • Provide the full board:config used for testing on Sabre-6quad.
      • The testing logs are placeholders. Include actual logs demonstrating the problem before the change and the fix after the change.

Recommendations:

  1. Elaborate on the problem: Clearly explain the issue caused by the watchdog timer handler changing the current task. Why is it necessary to run the scheduler before the watchdog timer handler? What are the consequences of not doing so?
  2. Detail the solution: Describe the specific code changes you made to address the problem. How do your changes ensure the current task is not updated before the round-robin (RR) process?
  3. Provide specific impact information: For each impact category, provide concrete details instead of general statements.
  4. Complete the testing section: Replace the placeholders with:
    • The host OS, CPU, and compiler version used for testing.
    • The complete board:config used for testing on Sabre-6quad.
    • Actual testing logs demonstrating the problem before and the successful outcome after your changes.

By providing this missing information, your PR will be much clearer and easier for the NuttX maintainers to review.

@jerpelea jerpelea merged commit 38ddf7d into apache:master Oct 2, 2024
29 checks passed
@zyfeier zyfeier deleted the rr branch October 8, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants