Fix timers/arch_alarm.c:109:3: error: 'now' may be used uninitialized #14818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and timers/arch_alarm.c:150:51: error: 'ticks' may be used uninitialized Signed-off-by: Xiang Xiao <[email protected]>
github-actions
bot
added
Area: Drivers
lupyuen
approved these changes
Nov 16, 2024
acassis
reviewed
Nov 16, 2024
Comment on lines
-106
to
+107
| ONESHOT_TICK_CURRENT(g_oneshot_lower, &now); | ||
| clock_t now = 0; | ||
|
|
||
| ONESHOT_TICK_CURRENT(g_oneshot_lower, &now); |
There was a problem hiding this comment.
I think this modification is not necessary, since the ONESHOT_TICK_CURRENT will set it with the initial value. I think we did it just to fix the compiler warning, right?
There was a problem hiding this comment.
No, the value doesn't set if the driver doesn't implement the related callback after #14619.
raiden00pl
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
and timers/arch_alarm.c:150:51: error: 'ticks' may be used uninitialized
Impact
fix compiler warning
Testing
ci