fix: remove duplicated statistics of upd.drop #14828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Networking
xiaoxiang781216
approved these changes
Nov 17, 2024
acassis
requested changes
Nov 17, 2024
There was a problem hiding this comment.
@ChenChuang-23 please include the Summary comment in the commit log message
The valule of g_netstats.udp.drop has been increased in net_dataevent() function, while it is increased in udp_datahandler().
ChenChuang-23
force-pushed
the
master
branch
from
8f2709d
to
c9d191e
Compare
anchao
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
The valule of g_netstats.udp.drop has been increased in net_dataevent() function,
while it is increased in udp_datahandler().
Impact
The statistical count of lost packets is twice the actual count of lost packets..
Testing
**