-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace spin_lock_irqrestore with raw_spin_lock_irqrestore #15695
base: master
Are you sure you want to change the base?
Conversation
reason: raw_spin_lock_irqrestore has better performance. Signed-off-by: hujun5 <[email protected]>
reason: raw_spin_lock_irqrestore has better performance. Signed-off-by: hujun5 <[email protected]>
reason: raw_spin_lock_irqrestore has better performance. Signed-off-by: hujun5 <[email protected]>
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements as presented. The Impact and Testing sections are incomplete placeholders. While the Summary section identifies what changed, it lacks crucial context:
To make this PR compliant, the following needs to be addressed:
Example of an improved Summary:
By providing this missing information, the PR will be much easier to review and merge. |
Please do not make such changes. The meaning of raw_ in linux is to disable the preemption. We need to discuss API naming further. |
Could you update the impact and testing sections? What is the purpose of the change? |
Summary
replace spin_lock_irqrestore with raw_spin_lock_irqrestore
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.