[UI] Optimized style #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2023 04:35
Zzm0809
reviewed
Aug 17, 2023
| } | ||
|
|
||
| const tooltipContent = useMemo(() => { | ||
| return i18n.language === 'zh-CN' ? '访问 GitHub 仓库' : 'Visit GitHub repository'; |
Zzm0809
reviewed
Aug 17, 2023
| const [tooltipContent, icon] = useMemo(() => { | ||
| let tooltipContent; | ||
| if(i18n.language === 'zh-CN') { | ||
| tooltipContent = dark ? '切换到亮色模式' : '切换到暗色模式'; |
Zzm0809
reviewed
Aug 17, 2023
| "cdcingestion": "CDC集成", | ||
| "system": "系统" | ||
| "system": "系统管理" | ||
| }, | ||
| "playground": { |
There was a problem hiding this comment.
Chinese and English are separated by spaces.
Zzm0809
reviewed
Aug 17, 2023
| "tableInfo": "表信息", | ||
| "details": "详细", | ||
| "files": "文件" | ||
| "catalog": "Catalog目录", |
There was a problem hiding this comment.
Chinese and English are separated by spaces.
Zzm0809
reviewed
Aug 17, 2023
| import {useEffect, useState} from "react"; | ||
| import styles from "./catalog-tree.module.less" | ||
| import { useTranslation } from 'react-i18next'; | ||
| import { useCatalogStore } from "@src/store/catalogStore.ts"; | ||
|
|
||
| const CatalogTree = () => { | ||
| const { t } = useTranslation() | ||
| const [hoveredNode, setHoveredNode] = useState(null); | ||
| const [hoveredIcon, setHoveredIcon] = useState(false); // 新增一个状态来追踪图标的悬停状态 |
There was a problem hiding this comment.
why use usestate ，please use style
added 7 commits
August 18, 2023 18:52
# Conflicts: # paimon-web-server/src/main/resources/i18n/messages_zh_CN.properties # paimon-web-ui/src/api/endpoints.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Optimized style
Tests
API and Format
Documentation