Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introduce Playground #42

Merged
merged 7 commits into from
Sep 21, 2023
Merged

[Feature] Introduce Playground #42

merged 7 commits into from
Sep 21, 2023

Conversation

labbomb
Copy link
Member

@labbomb labbomb commented Sep 20, 2023

Purpose

New Playground module
image

Tests

API and Format

Documentation

paimon-web-ui-new/src/components/monaco-editor/index.tsx Outdated Show resolved Hide resolved
paimon-web-ui-new/src/components/monaco-editor/index.tsx Outdated Show resolved Hide resolved
paimon-web-ui-new/src/views/playground/index.tsx Outdated Show resolved Hide resolved
paimon-web-ui-new/src/views/playground/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labbomb, thanks for the contribution. I have left some comments for this pull request. PTAL.

paimon-web-ui-new/src/locales/zh/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/components/monaco-editor/type.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/router/routes.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/views/playground/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for @labbomb updates.

@SteNicholas SteNicholas merged commit 21dbca4 into apache:main Sep 21, 2023
2 checks passed
@SteNicholas SteNicholas changed the title feat: add playground [Feature] Introduce Playground Sep 21, 2023
@labbomb labbomb deleted the dev branch September 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants