Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] language hooks encapsulation & auto import configuration #43

Merged
merged 3 commits into from
Sep 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions paimon-web-ui-new/auto-imports.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ declare global {
const isReactive: typeof import('vue')['isReactive']
const isReadonly: typeof import('vue')['isReadonly']
const isRef: typeof import('vue')['isRef']
const locales: typeof import('./src/composables/locales')['default']
const mapActions: typeof import('pinia')['mapActions']
const mapGetters: typeof import('pinia')['mapGetters']
const mapState: typeof import('pinia')['mapState']
Expand All @@ -56,6 +57,7 @@ declare global {
const onBeforeUpdate: typeof import('vue')['onBeforeUpdate']
const onDeactivated: typeof import('vue')['onDeactivated']
const onErrorCaptured: typeof import('vue')['onErrorCaptured']
const onLogin: typeof import('./src/api/models/login')['onLogin']
const onMounted: typeof import('vue')['onMounted']
const onRenderTracked: typeof import('vue')['onRenderTracked']
const onRenderTriggered: typeof import('vue')['onRenderTriggered']
Expand All @@ -67,6 +69,7 @@ declare global {
const reactive: typeof import('vue')['reactive']
const readonly: typeof import('vue')['readonly']
const ref: typeof import('vue')['ref']
const request: typeof import('./src/api/request')['default']
const resolveComponent: typeof import('vue')['resolveComponent']
const setActivePinia: typeof import('pinia')['setActivePinia']
const setMapStoreSuffix: typeof import('pinia')['setMapStoreSuffix']
Expand All @@ -79,13 +82,15 @@ declare global {
const toRefs: typeof import('vue')['toRefs']
const toValue: typeof import('vue')['toValue']
const triggerRef: typeof import('vue')['triggerRef']
const types: typeof import('./src/api/types')['default']
const unref: typeof import('vue')['unref']
const useAttrs: typeof import('vue')['useAttrs']
const useCssModule: typeof import('vue')['useCssModule']
const useCssVars: typeof import('vue')['useCssVars']
const useDialog: typeof import('naive-ui')['useDialog']
const useLink: typeof import('vue-router')['useLink']
const useLoadingBar: typeof import('naive-ui')['useLoadingBar']
const useLocaleHooks: typeof import('./src/composables/locales')['useLocaleHooks']
const useMessage: typeof import('naive-ui')['useMessage']
const useNotification: typeof import('naive-ui')['useNotification']
const useRoute: typeof import('vue-router')['useRoute']
Expand Down
21 changes: 17 additions & 4 deletions paimon-web-ui-new/src/composables/locales.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,25 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */

import { useI18n } from 'vue-i18n'
import {type UseI18nOptions } from 'vue-i18n'

export const useLocaleHooks = () => {
const { t } = useI18n()
import i18n, { LANGUAGES } from '@/locales'

type LocaleType = Pick<typeof i18n.global, 't' | 'n' | 'd'> & {
setLanguage(locale: UseI18nOptions['locale']): void
}

export const useLocaleHooks = (): LocaleType => {
const { t, d, n, locale } = i18n.global

const setLanguage = (newLanguage: LANGUAGES) => {
locale.value = newLanguage
}

return {
t
t,
n,
d,
setLanguage
}
}
47 changes: 18 additions & 29 deletions paimon-web-ui-new/src/layouts/content/components/menubar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,40 +15,29 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */

import i18n from '@/locales'
import { useConfigStore } from '@/store/config'

export default defineComponent({
name: 'MenuBar',
setup() {
const configStore = useConfigStore()

const menuOptions = ref([] as any[])
const { t } = useLocaleHooks()

watch(
() => configStore.getCurrentLocale,
() => {
menuOptions.value = [
{
label: i18n.global.t('layout.playground'),
key: 'playground',
},
{
label: i18n.global.t('layout.metadata'),
key: 'metadata',
},
{
label: i18n.global.t('layout.cdc_ingestion'),
key: 'cdc_ingestion',
},
{
label: i18n.global.t('layout.system'),
key: 'system',
},
]
const menuOptions = computed(() => ([
{
label: t('layout.playground'),
key: 'playground',
},
{ immediate: true }
)
{
label: t('layout.metadata'),
key: 'metadata',
},
{
label: t('layout.cdc_ingestion'),
key: 'cdc_ingestion',
},
{
label: t('layout.system'),
key: 'system',
},
]))

return {
activeKey: ref<string | null>('playground'),
Expand Down
22 changes: 14 additions & 8 deletions paimon-web-ui-new/src/layouts/content/components/toolbar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,16 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */

import i18n from '@/locales'
import { LANGUAGES } from '@/locales'
import { useConfigStore } from '@/store/config'
import { LogoGithub, Moon, SunnyOutline, Language, PersonCircleOutline } from '@vicons/ionicons5'
import { LogoGithub, Moon, SunnyOutline, Language } from '@vicons/ionicons5'

// ts-ignore
export default defineComponent({
name: 'ToolBar',
setup() {
const { t, setLanguage } = useLocaleHooks()

const handleLink = () => {
window.open('https://github.com/apache/incubator-paimon-webui')
}
Expand All @@ -34,19 +37,22 @@ export default defineComponent({
}

const handleLanguage = () => {
configStore.setCurrentLocale(configStore.getCurrentLocale === 'zh' ? 'en' : 'zh')
i18n.global.locale.value = configStore.getCurrentLocale === 'zh' ? 'en' : 'zh'
const lang = configStore.getCurrentLocale === LANGUAGES.ZH ? LANGUAGES.EN : LANGUAGES.ZH

configStore.setCurrentLocale(lang)
setLanguage(lang)
}

return {
t,
handleLink,
handleTheme,
handleLanguage,
configStore,
active: ref(false)
}
},
render () {
render() {
return (
<n-space align="center" size={20}>
<n-popover trigger="hover" placement="bottom"
Expand All @@ -59,8 +65,8 @@ export default defineComponent({
</n-icon>
)
}}
>
<span>{i18n.global.t('layout.' + String(this.configStore.getCurrentTheme === 'light' ? 'dark' : 'light'))}</span>
>
<span>{this.t('layout.' + String(this.configStore.getCurrentTheme === 'light' ? 'dark' : 'light'))}</span>
</n-popover>
<n-icon size="24" onClick={this.handleLink}>
<LogoGithub />
Expand Down
11 changes: 8 additions & 3 deletions paimon-web-ui-new/src/locales/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,19 @@ import { createI18n } from 'vue-i18n'
import en from './en'
import zh from './zh'

export enum LANGUAGES {
EN = 'en',
ZH = 'zh'
}

const i18n = createI18n({
locale: 'en',
locale: LANGUAGES.ZH,
legacy: false,
fallbackLocale: 'zh',
fallbackLocale: LANGUAGES.ZH,
messages: {
en,
zh
}
})

export default i18n
export default i18n
11 changes: 6 additions & 5 deletions paimon-web-ui-new/src/store/config/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,26 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */

import { LANGUAGES } from "@/locales"

type Theme = 'dark' | 'light'
type Locale = 'en' | 'zh'

export const useConfigStore = defineStore({
id: 'config',
state: (): { theme: Theme, locale: Locale } => ({
state: (): { theme: Theme, locale: LANGUAGES } => ({
theme: 'light',
locale: 'zh'
locale: LANGUAGES.ZH
}),
getters: {
getCurrentLocale(): Locale {
getCurrentLocale(): LANGUAGES {
return this.locale
},
getCurrentTheme(): Theme {
return this.theme
}
},
actions: {
setCurrentLocale(locale: Locale): void {
setCurrentLocale(locale: LANGUAGES): void {
this.locale = locale
},
setCurrentTheme(theme: Theme): void {
Expand Down
22 changes: 13 additions & 9 deletions paimon-web-ui-new/src/views/login/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,28 @@ under the License. */

import { useForm } from './use-form'
import { useConfigStore } from '@/store/config'
import i18n from '@/locales'
import { LANGUAGES } from '@/locales'
import logoImage from '@/assets/logo.svg'
import styles from './index.module.scss'

export default defineComponent({
name: 'LoginPage',
setup() {
const { t, setLanguage } = useLocaleHooks()
const { state, handleLogin } = useForm()

const configStore = useConfigStore()

const handleLocale = () => {
configStore.setCurrentLocale(configStore.getCurrentLocale === 'zh' ? 'en' : 'zh')
i18n.global.locale.value = configStore.getCurrentLocale === 'zh' ? 'en' : 'zh'
const lang = configStore.getCurrentLocale === LANGUAGES.ZH ? LANGUAGES.EN : LANGUAGES.ZH

configStore.setCurrentLocale(lang)
setLanguage(lang)
}

return {
configStore,
t,
handleLogin,
handleLocale,
...toRefs(state)
Expand All @@ -56,26 +60,26 @@ export default defineComponent({
style={{marginTop: '50px'}}
>
<n-form-item
label={i18n.global.t('login.username')}
label={this.t('login.username')}
path='userName'
>
<n-input
clearable
v-model={[this.model.username, 'value']}
placeholder={i18n.global.t('login.username_tips')}
placeholder={this.t('login.username_tips')}
autofocus
size='large'
/>
</n-form-item>
<n-form-item
label={i18n.global.t('login.password')}
label={this.t('login.password')}
path='userPassword'
>
<n-input
clearable
type='password'
v-model={[this.model.password, 'value']}
placeholder={i18n.global.t('login.password_tips')}
placeholder={this.t('login.password_tips')}
size='large'
/>
</n-form-item>
Expand All @@ -86,7 +90,7 @@ export default defineComponent({
style={{ width: '100%' }}
onClick={this.handleLogin}
>
{i18n.global.t('login.login')}
{this.t('login.login')}
</n-button>
</n-form>
<n-space justify='center' style={{marginTop: '80px'}}>
Expand All @@ -98,7 +102,7 @@ export default defineComponent({
this.configStore.getCurrentTheme === 'light' ? 'dark' : 'light'
)}
>
{i18n.global.t('login.' + String(this.configStore.getCurrentTheme === 'light' ? 'dark' : 'light'))}
{this.t('login.' + String(this.configStore.getCurrentTheme === 'light' ? 'dark' : 'light'))}
</n-button>
<n-button
quaternary
Expand Down
1 change: 0 additions & 1 deletion paimon-web-ui-new/src/views/login/use-form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */

import { onLogin } from '@/api'
import type { FormValidationError } from 'naive-ui'
import type { Router } from 'vue-router'

Expand Down
1 change: 0 additions & 1 deletion paimon-web-ui-new/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"include": ["env.d.ts", "src/**/*", "src/**/*.vue","src/**/*.tsx","./auto-imports.d.ts" ],
"exclude": ["src/**/__tests__/*"],
"compilerOptions": {
"composite": true,
"baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
Expand Down
4 changes: 4 additions & 0 deletions paimon-web-ui-new/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ export default defineConfig({
}
],
dts: './auto-imports.d.ts',
dirs: [
'./src/composables',
'./src/api/models',
],
eslintrc: {
enabled: false
}
Expand Down
Loading