[Improvement] Refactor api module #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
requested changes
Sep 30, 2023
There was a problem hiding this comment.
@s7monk, thanks for the contribution. I'm confused about why you introduce the catalog in the refactoring API module? Meanwhile, why not directly use catalog of Paimon?
paimon-web-api/src/main/java/org/apache/paimon/web/api/catalog/PaimonCatalog.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/catalog/PaimonCatalogFactory.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Outdated
Show resolved
Hide resolved
|
@SteNicholas Thanks for your review, I have updated this PR，PTAL. |
SteNicholas
requested changes
Oct 9, 2023
There was a problem hiding this comment.
@s7monk, thanks for updates. I left some comments for updates. PTAL.
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/catalog/PaimonServiceFactory.java
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/exception/ColumnException.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/exception/ColumnException.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/exception/ColumnException.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/ColumnMetadata.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/test/java/org/apache/paimon/web/api/catalog/PaimonServiceTest.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/test/java/org/apache/paimon/web/api/catalog/PaimonServiceTest.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/test/java/org/apache/paimon/web/api/catalog/PaimonServiceTest.java
Show resolved
Hide resolved
paimon-web-common/src/main/java/org/apache/paimon/web/common/utils/ParameterValidationUtil.java
Outdated
Show resolved
Hide resolved
SteNicholas
requested changes
Oct 10, 2023
paimon-web-api/src/main/java/org/apache/paimon/web/api/table/TableChange.java
Outdated
Show resolved
Hide resolved
paimon-web-api/src/test/java/org/apache/paimon/web/api/catalog/PaimonServiceTest.java
Show resolved
Hide resolved
SteNicholas
approved these changes
Oct 10, 2023
SteNicholas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[API] Refactor api module
Tests
PaimonCatalogTest
API and Format
Documentation