Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add playground module #46

Merged
merged 4 commits into from
Oct 6, 2023
Merged

[Feature] Add playground module #46

merged 4 commits into from
Oct 6, 2023

Conversation

labbomb
Copy link
Member

@labbomb labbomb commented Oct 2, 2023

image

Purpose

Please refer to the main issue #44

Tests

API and Format

Documentation

@labbomb labbomb changed the title [Feature] add playground module [Feature] Add playground module Oct 2, 2023
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labbomb, thanks for contribution. I left some minor comments for this pull request. PTAL.

paimon-web-ui-new/pnpm-lock.yaml Show resolved Hide resolved
paimon-web-ui-new/src/locales/en/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/locales/zh/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/locales/zh/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/locales/en/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/router/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/locales/en/modules/playground.ts Outdated Show resolved Hide resolved
paimon-web-ui-new/src/locales/zh/modules/playground.ts Outdated Show resolved Hide resolved
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for @labbomb updates.

@SteNicholas SteNicholas merged commit fb38935 into apache:main Oct 6, 2023
2 checks passed
@labbomb labbomb deleted the dev branch October 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants