[Improvement] Refactor server module #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2023 02:51
s7monk
changed the title
SteNicholas
requested changes
Oct 11, 2023
There was a problem hiding this comment.
@s7monk, thanks for the contribution. I left some comments for this pull request. PTAL.
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/CatalogController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/DatabaseController.java
Outdated
Show resolved
Hide resolved
...-web-server/src/test/java/org/apache/paimon/web/server/controller/CatalogControllerTest.java
Outdated
Show resolved
Hide resolved
...-web-server/src/test/java/org/apache/paimon/web/server/controller/CatalogControllerTest.java
Show resolved
Hide resolved
...web-server/src/test/java/org/apache/paimon/web/server/controller/DatabaseControllerTest.java
Show resolved
Hide resolved
added 3 commits
October 12, 2023 16:33
SteNicholas
requested changes
Oct 13, 2023
There was a problem hiding this comment.
@s7monk, thanks for updates. I have left some comments. PTAL.
|
|
||
| spring: | ||
| datasource: | ||
| url: jdbc:mysql://${MYSQL_ADDR:43.143.237.199:3306}/${MYSQL_DATABASE:paimon}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true |
There was a problem hiding this comment.
@s7monk, pls do not expose the IP in any files.
SteNicholas
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor server module.
Tests
API and Format
Documentation