-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve metadata model #54
Conversation
Perfect metadata model re apache#51
@SteNicholas I have fixed them, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunter-cloud09, thanks for updates. I left some comments for the updates. PTAL.
paimon-web-server/src/main/java/org/apache/paimon/web/server/constant/MetadataConstant.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/MetadataController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/MetadataController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/MetadataController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/controller/MetadataController.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/MetadataService.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/MetadataService.java
Outdated
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/MetadataService.java
Outdated
Show resolved
Hide resolved
...-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java
Outdated
Show resolved
Hide resolved
...web-server/src/test/java/org/apache/paimon/web/server/controller/MetadataControllerTest.java
Outdated
Show resolved
Hide resolved
@SteNicholas Fixed, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunter-cloud09, there are some style that could be improved. PTAL.
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/dto/QueryMetadataDTO.java
Show resolved
Hide resolved
...on-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java
Show resolved
Hide resolved
paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/DataFileVO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Perfect metadata model
re #51