Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize router & metadata Menu #64

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[Feature] Optimize router & metadata Menu #64

merged 3 commits into from
Oct 18, 2023

Conversation

zhangmo8
Copy link
Member

@zhangmo8 zhangmo8 commented Oct 17, 2023

Purpose

Optimize router & metadata Mena.

Tests

API and Format

Documentation

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @SteNicholas PTAL.

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangmo8, thanks for the contribution. I left minor comments for this pull request. PTAL.

@SteNicholas SteNicholas changed the title [Feature] Optimization router & metadata Menu [Feature] Optimize router & metadata Menu Oct 17, 2023
@zhangmo8 zhangmo8 closed this Oct 18, 2023
@zhangmo8 zhangmo8 reopened this Oct 18, 2023
Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for @zhangmo8 updates.

@SteNicholas SteNicholas merged commit 492e01b into apache:main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants