Skip to content

Commit

Permalink
run mima checks (#138)
Browse files Browse the repository at this point in the history
* run mima checks

* hardcode mima version due to build issues
  • Loading branch information
pjfanning authored Nov 13, 2023
1 parent 8e871ad commit 1ad7990
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 3 deletions.
37 changes: 37 additions & 0 deletions .github/workflows/mima-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: MiMa Check

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
tags-ignore: [ v.* ]

jobs:
test:
name: Build and Test
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Checkout GitHub merge
if: github.event.pull_request
run: |-
git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
git checkout scratch
- name: Setup Java 8
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 8

- name: Cache Coursier cache
uses: coursier/[email protected]

- name: Check code formatted
run: sbt +mimaReportBinaryIssues
8 changes: 5 additions & 3 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ lazy val root = project
GlobalScope / parallelExecution := false)
.enablePlugins(NoPublish)

lazy val mimaPreviousArtifactsSet = mimaPreviousArtifacts := Set.empty // temporarily disable mima checks
val mimaCompareVersion = "1.0.0"
lazy val mimaPreviousArtifactsSet = mimaPreviousArtifacts := Set(
organization.value %% name.value % mimaCompareVersion)

lazy val discoveryKubernetesApi = pekkoModule("discovery-kubernetes-api")
.enablePlugins(AutomateHeaderPlugin, ReproducibleBuildsPlugin)
Expand Down Expand Up @@ -129,10 +131,10 @@ lazy val managementLoglevelsLogback = pekkoModule("management-loglevels-logback"

lazy val managementLoglevelsLog4j2 = pekkoModule("management-loglevels-log4j2")
.enablePlugins(AutomateHeaderPlugin, ReproducibleBuildsPlugin)
.disablePlugins(MimaPlugin)
.settings(
name := "pekko-management-loglevels-log4j2",
libraryDependencies := Dependencies.managementLoglevelsLog4j2)
libraryDependencies := Dependencies.managementLoglevelsLog4j2,
mimaPreviousArtifactsSet)
.dependsOn(management)

lazy val managementClusterHttp = pekkoModule("management-cluster-http")
Expand Down

0 comments on commit 1ad7990

Please sign in to comment.