Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly build tests #139

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix nightly build tests #139

merged 1 commit into from
Nov 13, 2023

Conversation

pjfanning
Copy link
Contributor

  • 'main' pekko is v1.1.0-SNAPSHOT and it includes slf4j v2
  • when building with 'main' - we need to skip the loglevel tests that are sensitive to the slf4j version
  • we will not publish with 'main' - so this only affects what tests we run

Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit b4b9c68 into apache:main Nov 13, 2023
@pjfanning pjfanning deleted the fix-nightly branch November 13, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants