Use sbt-apache-sonatype #26
Conversation
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
| @@ -10,9 +10,9 @@ enablePlugins(JavaServerAppPackaging) | |||
|
|
|||
| dockerUsername := sys.env.get("DOCKER_USER") | |||
|
|
|||
| val akkaManagementVersion = "1.1.4" | |||
| val pekkoManagementVersion = "1.1.4" | |||
There was a problem hiding this comment.
@pjfanning @nvollmar I was looking into the history of this file and I noticed that this version was bumped from 0.10.0 to 1.1.4. What is the context behind this, seems kind of random?
There was a problem hiding this comment.
I'm not even sure this is what we want, we probably want to get these pekko libs from local M2 repo - we don't want to test released versions of these libs (and there are no pekko released versions)
There was a problem hiding this comment.
So then I don't even know what this version is here for, it seems we can put whatever we wan't and it "works" (in which case it should be documented because its highly confusing)?
I mean there is no pekko 1.1.4 and it shouldn't be resolving any akka artifacts now???
There was a problem hiding this comment.
I ran into that and thought it strange to test against an obsolete version. Just re-checked now and it seems those tests aren't run at all.
There was a problem hiding this comment.
Checking the Readme, the following projects are/were not maintained by Lightbend and were left to the community:
- akka-discovery-marathon-api
- akka-discovery-aws-api
- akka-discovery-aws-api-async
- akka-discovery-consul
We might discuss how to go forward with them: Drop them, leave them as is or start maintaining them?
There was a problem hiding this comment.
The kubernetes api tests do a local publish and any version specified is overwritten with the local published one.
There was a problem hiding this comment.
It seems that particular module is part of "integration-tests" but really is an example that contains no tests itself.
mdedetrich
force-pushed
the
use-sbt-apache-sonatype
branch
from
362c9c0 to
f3a9b49
Compare
|
So one of the tests are failing, will have to look into it |
|
Some of the tests are a bit flaky, I guess this project needs a bit more work in general |
|
Ah, it just passed. You are right it is flaky tests (I didn't think this project had flaky tests but good to know) |
No description provided.