-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix leak in FlatMapPrefix operator. #1622
Conversation
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/FlatMapPrefix.scala
Show resolved
Hide resolved
@pjfanning Would you like to give this a review? |
Would it be possible to unit test this? We probably don't want anything that takes too much time or memory to run but it might be feasible to add some extra test coverage. |
I think I can't test it because the builder is protected inside the logic, otherwise, I have to extract the code to a dedicated class and expose it to tests. Another way is using the MBean, but that is too much. |
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/FlatMapPrefix.scala
Show resolved
Hide resolved
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/FlatMapPrefix.scala
Outdated
Show resolved
Hide resolved
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/FlatMapPrefix.scala
Show resolved
Hide resolved
9373a45
to
bc37570
Compare
@queimadus Thanks for the reporting, this do spend me a weekend to work out:) |
extracted from #1621
Motivation:
In #1566 , @queimadus points out a leak
Modification:
Result:
leak fixed.