fix: avoid call finalizeStage more times than once. #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
requested review from
jrudolph,
alexandru,
nvollmar,
mdedetrich and
pjfanning
pjfanning
reviewed
Dec 31, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/GraphInterpreter.scala
Outdated
Show resolved
Hide resolved
|
Overall, it looks good. Shouldn't the change also be applied to the |
He-Pin
commented
Dec 31, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/GraphInterpreter.scala
Show resolved
Hide resolved
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Dec 31, 2024
(cherry picked from commit 7fef5b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
fix #1646
Modification:
Avoid calling
finalizeStage(logic)many times.Result:
No NPE on 1.1.x
forward port, there is no NPE on 1.1.x, but the
finalizeStagecan still be called many times.