Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failed in StreamConvertersSpec #1655

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 31, 2024

Motivation:
refs: #1653

Modification:
Implemented the splitIterator in test

Result:
Tests run ok.

@He-Pin He-Pin added the t:stream Pekko Streams label Dec 31, 2024
@He-Pin He-Pin linked an issue Dec 31, 2024 that may be closed by this pull request
@He-Pin He-Pin added this to the 1.2.0 milestone Dec 31, 2024
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Contributor

since this was likely caused by #1249, I think this should be backfit

@He-Pin He-Pin merged commit def84bf into apache:main Dec 31, 2024
8 checks passed
@He-Pin He-Pin deleted the StreamConvertersSpec branch December 31, 2024 13:33
He-Pin added a commit to He-Pin/incubator-pekko that referenced this pull request Dec 31, 2024
He-Pin added a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed: StreamConvertersSpec, an implementation is missing
2 participants