feat: Add emitMulti with Spliterator support #1776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning Would you like to take a look at this, thank. |
Can you give some background on who needs this? Is it intended that anyone can use this or do you just want it for #1775? |
For now, only in #1775 , but it's generally |
|
the code is protected - so other users won't easily be able to access it |
He-Pin
commented
Feb 26, 2025
| * is needed and reinstalls the current handler upon receiving an `onPull()` | ||
| * signal (before invoking the `andThen` function). | ||
| */ | ||
| final protected def emitMultiple[T](out: Outlet[T], elems: Spliterator[T], andThen: () => Unit): Unit = { |
There was a problem hiding this comment.
@pjfanning It the same access level as the other emitMultiple method, its been used in a sub class of GraphStage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add Spliterator support for emitMulti, reducing overhead when working with java stream.
Result:
less overhead
I would like rebase #1775 on this.