Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust log-on-startup docs #815

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

pjfanning
Copy link
Contributor

we don't want to encourage the use of this in production


```ruby
pekko {
# Log the complete configuration at INFO level when the actor system is started.
# This logging can include sensitive values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add words like consider turn this off in production?

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 2ebec03 into apache:main Nov 26, 2023
17 of 18 checks passed
@pjfanning pjfanning deleted the adjust-log-on-startup-docs branch November 26, 2023 09:55
pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Nov 26, 2023
* adjust log-on-startup docs

* update message
pjfanning added a commit that referenced this pull request Nov 26, 2023
* adjust log-on-startup docs

* update message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants