rework noisy dns log (#835)

[pjfanning]

cherry pick f6af100 #835 #834

[mdedetrich]

Hmm, is this needed for Pekko 1.0.x? Technically speaking it is a behavioural change and its not actually fixing any critical bugs/security fixes.

I would actually argue that such a change is not a good thing because if people migrate from Akka to Pekko 1.0.x and they suddenly see a difference in logs their initial assumption (even if incorrect) may be that Pekko might have "broken" something or their migration "didn't work".

[pjfanning]

I'll go with the consensus but this log is not an Akka log - it was added by c56edca

My opinion is that this log message is incorrect in what it says, is unnecessary and logs excessively.

[mdedetrich]

So just to clarify, the change in c56edca modified the logging (so its now spitting more logs then it used to) and this cherry pick commit fixes that?

[pjfanning]

So just to clarify, the change in c56edca modified the logging (so its now spitting more logs then it used to) and this cherry pick commit fixes that?

Yes. The change in Pekko makes the logs noisier. The log statement that I am modifying seems to be a copy paste with small mods from the previous case - but this case is basically the success path and it issues a warning log when nothing is wrong.

@SakulK you reported the original issue (#834) - would you be able to comment on this?

[mdedetrich]

Thanks for clearing that up, I will tentatively approve this (by tentatively I mean it would be good to get some feedback from others, i.e. @SakulK)

[SakulK]

This log wasn't happening with Akka, so during migration to Pekko it got me worried that something is broken (especially since the log level is WARN). So I guess this PR would revert an observable difference between Akka and Pekko 1.0.x

[mdedetrich]

This log wasn't happening with Akka, so during migration to Pekko it got me worried that something is broken (especially since the log level is WARN). So I guess this PR would revert an observable difference between Akka and Pekko 1.0.x

Thanks for confirming, in this case it's good to merge.