Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix RecipeAdhocSource test. #888

Merged
merged 1 commit into from
Dec 28, 2023
Merged

chore: Fix RecipeAdhocSource test. #888

merged 1 commit into from
Dec 28, 2023

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 28, 2023

refs: #886

@He-Pin He-Pin force-pushed the fixRecipeAdhocSource branch from ff09b28 to da082d4 Compare December 28, 2023 09:20
@He-Pin He-Pin requested a review from pjfanning December 28, 2023 09:25
@@ -14,11 +14,12 @@
package docs.stream.cookbook

import java.util.concurrent.atomic.{ AtomicBoolean, AtomicInteger }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have modified the import here, I think keep black line to separate org. apache. pekko and java. util
besides I think the dependencies of pekko should be on the top part

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I can do that later with a sortImports.

@laglangyue
Copy link
Contributor

lgtm if ci passed

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit d829637 into main Dec 28, 2023
18 checks passed
@He-Pin He-Pin deleted the fixRecipeAdhocSource branch December 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants