Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7133 Update maven plugin versions in connectors #123

Closed
wants to merge 1 commit into from
Closed

PHOENIX-7133 Update maven plugin versions in connectors #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,14 @@
<commons-io.version>2.11.0</commons-io.version>

<!-- Plugin versions -->
<maven-assembly-plugin-version>3.1.1</maven-assembly-plugin-version>
<surefire.version>3.0.0</surefire.version>
<maven-project-info-reports-plugin.version>3.1.1</maven-project-info-reports-plugin.version>
<maven-checkstyle-plugin.version>3.1.0</maven-checkstyle-plugin.version>
<maven-build-helper-plugin.version>3.2.0</maven-build-helper-plugin.version>
<maven-scala-plugin.version>3.4.4</maven-scala-plugin.version>
<maven-build-helper-plugin.version>3.5.0</maven-build-helper-plugin.version>
<scala-maven-plugin.version>4.8.1</scala-maven-plugin.version>

<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<spotbugs-maven-plugin.version>4.1.3</spotbugs-maven-plugin.version>
<spotbugs.version>4.1.3</spotbugs.version>
<maven-owasp-plugin.version>6.5.3</maven-owasp-plugin.version>
<exec-maven-plugin.version>3.1.0</exec-maven-plugin.version>
<spotbugs-maven-plugin.version>4.8.1.0</spotbugs-maven-plugin.version>
<spotbugs.version>4.8.2</spotbugs.version>
<maven-owasp-plugin.version>9.0.1</maven-owasp-plugin.version>
<maven.bundle.version>3.3.0</maven.bundle.version>

<!-- Plugin options -->
<numForkedUT>8</numForkedUT>
Expand Down Expand Up @@ -181,7 +178,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>${maven-project-info-reports-plugin.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we set any version for these plugins?
This way we will use the version that is coming from apache parent right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to override the apache parent's versions if we have to.
Any since these are old, the managed versions are all going to be newer.

</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand All @@ -190,7 +186,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<version>${maven-assembly-plugin-version}</version>
</plugin>
<!--This plugin's configuration is used to store Eclipse m2e settings
only. It has no influence on the Maven build itself. -->
Expand Down Expand Up @@ -221,7 +216,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
Expand Down Expand Up @@ -297,7 +291,7 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
<version>${maven-scala-plugin.version}</version>
<version>${scala-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down Expand Up @@ -346,10 +340,11 @@
</configuration>
</plugin>
<plugin>
<!-- Allows us to get the apache-ds bundle artifacts -->
<!-- Allows us to get the apache-ds bundle artifacts
TODO What does that mean ? We don't even use this directly. -->
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>2.5.3</version>
<version>${maven.bundle.version}</version>
</plugin>
</plugins>
</pluginManagement>
Expand All @@ -375,6 +370,15 @@
</goals>
</execution>
</executions>
<!-- FIXME This is an older version, as the current checkstyle configuration doesn't work
on newer checkstyle versions.-->
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>8.19</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
Loading