Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7168 Remove shaded protobuf from shaded connector JARs #128

Closed
wants to merge 1 commit into from
Closed

PHOENIX-7168 Remove shaded protobuf from shaded connector JARs #128

wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Jan 10, 2024 •
edited
Loading

This is a re-upload of #126 which seems to have gotten corrupted (on the github.com side)

@stoty
Copy link
Contributor Author

stoty commented Jan 10, 2024

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 10m 15s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 7s root in master failed.
-1 ❌ compile 0m 10s phoenix5-hive-shaded in master failed.
-1 ❌ compile 0m 9s phoenix5-spark3-shaded in master failed.
-1 ❌ compile 0m 7s phoenix5-spark-shaded in master failed.
-1 ❌ javadoc 0m 6s phoenix5-hive-shaded in master failed.
-1 ❌ javadoc 0m 5s phoenix5-spark3-shaded in master failed.
-1 ❌ javadoc 0m 5s phoenix5-spark-shaded in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 5s root in the patch failed.
-1 ❌ compile 0m 6s phoenix5-hive-shaded in the patch failed.
-1 ❌ compile 0m 5s phoenix5-spark3-shaded in the patch failed.
-1 ❌ compile 0m 6s phoenix5-spark-shaded in the patch failed.
-1 ❌ javac 0m 6s phoenix5-hive-shaded in the patch failed.
-1 ❌ javac 0m 5s phoenix5-spark3-shaded in the patch failed.
-1 ❌ javac 0m 6s phoenix5-spark-shaded in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 6s phoenix5-hive-shaded in the patch failed.
-1 ❌ javadoc 0m 5s phoenix5-spark3-shaded in the patch failed.
-1 ❌ javadoc 0m 6s phoenix5-spark-shaded in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 6s phoenix5-hive-shaded in the patch failed.
-1 ❌ unit 0m 5s phoenix5-spark3-shaded in the patch failed.
-1 ❌ unit 0m 6s phoenix5-spark-shaded in the patch failed.
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
16m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #128
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux a38f002ef13e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 60d4172
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark-shaded.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3-shaded.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3-shaded.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3-shaded.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-unit-phoenix5-hive-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3-shaded.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark-shaded.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-hive-shaded phoenix5-spark3-shaded phoenix5-spark-shaded U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty requested a review from richardantal January 10, 2024 08:26
richardantal
richardantal approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty closed this Jan 10, 2024
@stoty
Copy link
Contributor Author

stoty commented Jan 10, 2024

merged manually

@stoty stoty mentioned this pull request Aug 18, 2024
Merged
@stoty stoty mentioned this pull request Sep 13, 2024
Closed
@stoty stoty mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardantal richardantal richardantal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @richardantal