Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6166 Make Tephra support optional for phoenix 5 connectors #130

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Feb 9, 2024

No description provided.

@stoty stoty requested a review from richardantal February 9, 2024 17:15
@stoty
Copy link
Contributor Author

stoty commented Feb 9, 2024

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 10m 17s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 8s root in master failed.
-1 ❌ compile 0m 8s phoenix5-hive in master failed.
-1 ❌ compile 0m 9s phoenix5-spark in master failed.
-1 ❌ compile 0m 8s phoenix5-spark3 in master failed.
-1 ❌ javadoc 0m 9s phoenix5-hive in master failed.
-1 ❌ javadoc 0m 9s phoenix5-spark in master failed.
-1 ❌ javadoc 0m 9s phoenix5-spark3 in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 6s root in the patch failed.
-1 ❌ compile 0m 9s phoenix5-hive in the patch failed.
-1 ❌ compile 0m 8s phoenix5-spark in the patch failed.
-1 ❌ compile 0m 8s phoenix5-spark3 in the patch failed.
-1 ❌ javac 0m 9s phoenix5-hive in the patch failed.
-1 ❌ javac 0m 8s phoenix5-spark in the patch failed.
-1 ❌ javac 0m 8s phoenix5-spark3 in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 9s phoenix5-hive in the patch failed.
-1 ❌ javadoc 0m 9s phoenix5-spark in the patch failed.
-1 ❌ javadoc 0m 9s phoenix5-spark3 in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 10s phoenix5-hive in the patch failed.
-1 ❌ unit 0m 8s phoenix5-spark in the patch failed.
-1 ❌ unit 0m 9s phoenix5-spark3 in the patch failed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
20m 11s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #130
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 2eec73f7b6ce 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 6d57726
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-hive.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: phoenix5-hive phoenix5-spark phoenix5-spark3 U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty
Copy link
Contributor Author

stoty commented Feb 12, 2024

merged manually

@stoty stoty closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants