PHOENIX-7366 Use Phoenix 5.2 to compile phoenix-connectors #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also refactor maven project setup also merge phoenix5-spark3-it back into phoenix5-spark module
|
The actal java changes are minimal, most of the changes is optimizing the pom.xmls, and merging the spark3 ITs back into the main module. |
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
I think It could have been better if phoenix 5.2 support was separated from the refactoring.
I can't comment it on the file but please remove the empty phoenix5-hive/README.md file at https://github.com/stoty/phoenix-connectors/blob/PHOENIX-7366/phoenix5-hive/README.md
otherwise It looks Good to me
phoenix5-spark/pom.xml
Outdated
| <artifactId>maven-dependency-plugin</artifactId> | ||
| <configuration> | ||
| <ignoredUnusedDeclaredDependencies> | ||
| <!-- These are test runtime dependencies that Maven has conecnt |
| @@ -34,13 +34,16 @@ | |||
| import org.junit.Ignore; | |||
| import org.junit.Test; | |||
| import org.junit.experimental.categories.Category; | |||
| import org.slf4j.Logger; | |||
There was a problem hiding this comment.
I don't think it is beeing used
phoenix5-spark3/pom.xml
Outdated
| <ignoredUsedUndeclaredDependencies> | ||
| <!-- No trace of these in the source. Perhaps used anonymously | ||
| in chained method calls ? --> | ||
| <ignoredUsedUndeclaredDependency>joda-time:joda-time</ignoredUsedUndeclaredDependency> |
There was a problem hiding this comment.
| @@ -0,0 +1,90 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is not used anywhere, could you please remove it?
|
Thank you, @richardantal I have fixed the issues you found. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also refactor maven project setup
also merge phoenix5-spark3-it back into phoenix5-spark module