PHOENIX-6940 Add a connector variant for Hive 4 #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also: partially sync org.apache.phoenix.hive.ql.index classes to Hive 4 rename org.apache.phoenix.hive.ql.index package and classes remove HiveCompatUtil merge phoenix5-hive-it back into phoenix5-hive
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
I could not reproduce the problem dowstream, maybe it is related to Azul JVM ?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Tests are passing now. |
richardantal
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
LGTM
Most of the changes are related to HiveCompatUtil removal, IndexSearchCondition got renamed to PhoenixSearchCondition, and formatting as you mentioned
I see that the hive test files are (almost) identical to the ones in in hive 4.0.0 repo https://github.com/apache/hive/tree/rel/release-4.0.0/itests/util/src/main/java/org/apache/hadoop/hive/ql
I ran tests on the change successfully.
please add "3" to the name of phoenix5-hive-shaded module at
https://github.com/stoty/phoenix-connectors/blob/PHOENIX-6940/phoenix5-hive-shaded/pom.xml#L33
|
Thank you, fixed the module name |
|
merged manually. |
|
💔 -1 overall
This message was automatically generated. |
|
I have already merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also:
partially sync org.apache.phoenix.hive.ql.index classes to Hive 4 rename org.apache.phoenix.hive.ql.index package and classes remove HiveCompatUtil
merge phoenix5-hive-it back into phoenix5-hive