Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ssl handshake issue for self-signed certs #13752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmozaid
Copy link
Contributor

@kmozaid kmozaid commented Aug 6, 2024

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

@kmozaid kmozaid force-pushed the self_signed_certs_for_http_connection_pooling_manager branch from b452298 to 3925a16 Compare August 6, 2024 03:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.93%. Comparing base (59551e4) to head (3925a16).
Report is 835 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13752      +/-   ##
============================================
+ Coverage     61.75%   61.93%   +0.18%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2557     +121     
  Lines        133233   141045    +7812     
  Branches      20636    21933    +1297     
============================================
+ Hits          82274    87359    +5085     
- Misses        44911    47037    +2126     
- Partials       6048     6649     +601     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.89% <100.00%> (+0.18%) ⬆️
java-21 61.81% <100.00%> (+0.18%) ⬆️
skip-bytebuffers-false 61.90% <100.00%> (+0.15%) ⬆️
skip-bytebuffers-true 61.80% <100.00%> (+34.07%) ⬆️
temurin 61.93% <100.00%> (+0.18%) ⬆️
unittests 61.93% <100.00%> (+0.18%) ⬆️
unittests1 46.37% <ø> (-0.52%) ⬇️
unittests2 27.79% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants