Retain boolean type from CLPLogRecordExtractor decoder. #14497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14497 +/- ##
============================================
+ Coverage 61.75% 63.76% +2.01%
- Complexity 207 1566 +1359
============================================
Files 2436 2668 +232
Lines 133233 146470 +13237
Branches 20636 22467 +1831
============================================
+ Hits 82274 93399 +11125
- Misses 44911 46149 +1238
- Partials 6048 6922 +874
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
deemoliu
approved these changes
Nov 20, 2024
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behavior of CLPLogRecordExtractor to prevent Boolean fields from being cast to the string type. Searching for Boolean values in a string column can be confusing, particularly for users accustomed to different programming languages. For instance, Python uses True, while Java uses true, leading to potential inconsistencies.