Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential NPE in OffHeapSingleTreeBuilder.close() #14954

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Jackie-Jiang
Copy link
Contributor

_starTreeRecordBuffer might not be set when star-tree build is interrupted (e.g. throws exception)

@Jackie-Jiang Jackie-Jiang merged commit 8918974 into apache:master Jan 30, 2025
19 of 21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_startree_builder_npe branch January 30, 2025 19:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (59551e4) to head (ce3063b).
Report is 1652 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14954      +/-   ##
============================================
+ Coverage     61.75%   63.59%   +1.84%     
- Complexity      207     1385    +1178     
============================================
  Files          2436     2710     +274     
  Lines        133233   151925   +18692     
  Branches      20636    23464    +2828     
============================================
+ Hits          82274    96622   +14348     
- Misses        44911    48031    +3120     
- Partials       6048     7272    +1224     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 34.00% <50.00%> (-27.70%) ⬇️
java-21 63.59% <100.00%> (+1.97%) ⬆️
skip-bytebuffers-false 63.57% <100.00%> (+1.82%) ⬆️
skip-bytebuffers-true 63.57% <100.00%> (+35.84%) ⬆️
temurin 63.59% <100.00%> (+1.84%) ⬆️
unittests 63.59% <100.00%> (+1.84%) ⬆️
unittests1 56.08% <100.00%> (+9.19%) ⬆️
unittests2 34.01% <50.00%> (+6.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants