Skip to content

Commit

Permalink
Set minimum osx version to 13.0 and link CoreServices
Browse files Browse the repository at this point in the history
  • Loading branch information
BewareMyPower committed Dec 16, 2024
1 parent c4c1215 commit 796759e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-pr-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
clang++ win-examples/example.cc -o dynamic.out -std=c++11 -arch ${{ matrix.arch }} -I $PULSAR_DIR/include -L $PULSAR_DIR/lib -Wl,-rpath $PULSAR_DIR/lib -lpulsar
./dynamic.out
echo "Build with static library"
clang++ win-examples/example.cc -o static.out -std=c++11 -arch ${{ matrix.arch }} -I $PULSAR_DIR/include $PULSAR_DIR/lib/libpulsarwithdeps.a -framework SystemConfiguration -framework CoreFoundation
clang++ win-examples/example.cc -o static.out -std=c++11 -arch ${{ matrix.arch }} -I $PULSAR_DIR/include $PULSAR_DIR/lib/libpulsarwithdeps.a -framework SystemConfiguration -framework CoreServices -framework CoreFoundation
./static.out
check-completion:
Expand Down
2 changes: 1 addition & 1 deletion vcpkg-triplets/arm64-osx.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
set(VCPKG_OSX_ARCHITECTURES arm64)
set(VCPKG_OSX_DEPLOYMENT_TARGET 13.7)
set(VCPKG_OSX_DEPLOYMENT_TARGET 13.0)

set(VCPKG_BUILD_TYPE release)
2 changes: 1 addition & 1 deletion vcpkg-triplets/x64-osx.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
set(VCPKG_OSX_ARCHITECTURES x86_64)
set(VCPKG_OSX_DEPLOYMENT_TARGET 13.7)
set(VCPKG_OSX_DEPLOYMENT_TARGET 13.0)

set(VCPKG_BUILD_TYPE release)

0 comments on commit 796759e

Please sign in to comment.