Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add example for how to import the library #379

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

BewareMyPower
Copy link
Contributor

No description provided.

@BewareMyPower BewareMyPower added the documentation Improvements or additions to documentation label Dec 29, 2023
@BewareMyPower BewareMyPower added this to the 3.5.0 milestone Dec 29, 2023
@BewareMyPower BewareMyPower self-assigned this Dec 29, 2023
@BewareMyPower BewareMyPower marked this pull request as draft December 29, 2023 15:48
@BewareMyPower
Copy link
Contributor Author

There is a fix needed in the upstream. When CMAKE_BUILD_TYPE is not defined, the release library and debug library could be the same.

@BewareMyPower BewareMyPower marked this pull request as ready for review January 19, 2024 10:13

### Download pre-built binaries

For non-vcpkg projects, you can download pre-built binaries from the [official release page](https://pulsar.apache.org/download/#pulsar-c-client).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also need to update this doc? https://pulsar.apache.org/docs/3.1.x/client-libraries-cpp/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@RobertIndie
Copy link
Member

I am trying to run the example. But it throws the following errors when executing cmake -B build:

-- Running vcpkg install
pulsar-client-cpp does not exist
-- Running vcpkg install - failed
CMake Error at /Users/rbt/code/pulsar-client-cpp/vcpkg/scripts/buildsystems/vcpkg.cmake:899 (message):
  vcpkg install failed.  See logs for more information:
  /Users/rbt/code/pulsar-client-cpp/vcpkg-example/build/vcpkg-manifest-install.log
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.28.1/share/cmake/Modules/CMakeDetermineSystem.cmake:170 (include)
  CMakeLists.txt:10 (project)

CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

In /Users/rbt/code/pulsar-client-cpp/vcpkg-example/build/vcpkg-manifest-install.log:

pulsar-client-cpp does not exist

@BewareMyPower
Copy link
Contributor Author

BewareMyPower commented Jan 22, 2024

@RobertIndie Have you fetched the submodule? Please note that this PR also updates the commit of the vcpkg submodule. Could you run the following command and show the output?

cd vcpkg && git log --pretty=oneline | head -n 1

If you only ran git apply 379.diff, maybe it won't work.

@RobertIndie
Copy link
Member

@RobertIndie Have you fetched the submodule? Please note that this PR also updates the commit of the vcpkg submodule. Could you run the following command and show the output?

cd vcpkg && git log --pretty=oneline | head -n 1

If you only ran git apply 379.diff, maybe it won't work.

Thanks. It works now!

@BewareMyPower BewareMyPower merged commit e13bd6d into apache:main Jan 24, 2024
12 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/vcpkg branch February 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants