Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compiler warnings in public headers #468

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

erobot
Copy link
Contributor

@erobot erobot commented Dec 25, 2024

Motivation

Fix some compiler warnings in public headers when using with -Wextra. These warnings prevent projects using -Wextra -Werror to use pulsar client without modifications.

Modifications

  1. Modified public headers to fix compiler warnings
  2. Add compile options "-Wextra -Wno-unused-parameter" to compile examples to help find similar issues

Verifying this change

  • Make sure that the change passes the CI checks.

This change can be verified as follows:

  • Add compile options "-Wextra -Wno-unused-parameter" to compile examples to help find similar issues

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    Only the compiler warnings have been fixed, and there is no change in functionality.

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@erobot erobot force-pushed the fix-public-headers branch from 8502aed to fa4f99e Compare December 26, 2024 02:35
@BewareMyPower BewareMyPower added this to the 3.7.0 milestone Dec 26, 2024
@BewareMyPower
Copy link
Contributor

"Build CPP Client on macOS" failed because it builds with the latest dependency in homebrew. I will remove it from the workflow.

@BewareMyPower BewareMyPower merged commit bdf6854 into apache:main Dec 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants