[improve][broker] Avoid PersistentReplicator.expireMessages logic com…

…pute backlog twice (#23957)
apache · Feb 11, 2025 · 6db275c · 6db275c
1 parent 7f595cd
commit 6db275c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...roker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java b/...roker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java
@@ -670,8 +670,8 @@ public void updateMessageTTL(int messageTTLInSeconds) {
 
     @Override
     public boolean expireMessages(int messageTTLInSeconds) {
-        if ((cursor.getNumberOfEntriesInBacklog(false) == 0)
-                || (cursor.getNumberOfEntriesInBacklog(false) < MINIMUM_BACKLOG_FOR_EXPIRY_CHECK
+        long backlog = cursor.getNumberOfEntriesInBacklog(false);
+        if ((backlog == 0) || (backlog < MINIMUM_BACKLOG_FOR_EXPIRY_CHECK
                         && !topic.isOldestMessageExpired(cursor, messageTTLInSeconds))) {
             // don't do anything for almost caught-up connected subscriptions
             return false;