[fix][broker] Don't allow creating a non-persistent partitioned topic with '-partition-' in name #23488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, @hanmz. Would you be able to add a test case to cover this change? |
lhotari
changed the title
lhotari
approved these changes
Oct 23, 2024
OK, I've added a test case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23488 +/- ##
=============================================
- Coverage 73.57% 40.75% -32.83%
+ Complexity 32624 1417 -31207
=============================================
Files 1877 1805 -72
Lines 139502 148024 +8522
Branches 15299 17116 +1817
=============================================
- Hits 102638 60322 -42316
- Misses 28908 80090 +51182
+ Partials 7956 7612 -344
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Closing and reopening to trigger a new CI run |
|
/pulsarbot rerun-failure-checks |
|
reopen to trigger ci |
…topic name contain '-partition-'.
… with '-partition-' in name
hanmz
force-pushed
the
fix/non-persistent-partitioned-topic
branch
from
fbe1f32 to
1277fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we can create a non-persistent partition topic contain
-partition-.However, we cannot use it as a normal non-persistent partition topic. For example, when we use thepartitioned-statscommand, we will encounter errors.Partitioned Topic Name should not contain '-partition-'
Reason: Partitioned Topic Name should not contain '-partition-'
Modifications
We should disable the creation of non-persistent partition topics contain
-partition-.Documentation
Verifying this change
All unit tests passed, not have any behavior change.
docdoc-requireddoc-not-neededdoc-complete